Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix aot large model (--size-level=0) with LLVM 18 #3057

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Fix aot large model (--size-level=0) with LLVM 18 #3057

merged 1 commit into from
Jan 19, 2024

Conversation

yamt
Copy link
Collaborator

@yamt yamt commented Jan 19, 2024

The recent versions LLVM uses ".ltext" section for X86 large model.

cf. llvm/llvm-project@d8a0439

This fixes #3034

@yamt
Fix aot large model (--size-level=0) with LLVM 18
c70b3d1 
The recent versions LLVM uses ".ltext" section for X86 large model.

cf. llvm/llvm-project@d8a0439

This fixes bytecodealliance#3034
@yamt yamt marked this pull request as ready for review January 19, 2024 08:23
@yamt
Copy link
Collaborator Author

yamt commented Jan 19, 2024

the ci failure looks unrelated.

Download action repository 'actions/cache@v3' (SHA:e12d46a63a90f2fae62d114769bbf2a179198b5c)
Warning: Failed to download action 'https://api.github.com/repos/actions/cache/tarball/e12d46a63a90f2fae62d114769bbf2a179198b5c'. Error: nodename nor servname provided, or not known (api.github.com:443)
Warning: Back off 25.823 seconds before retry.
Warning: Failed to download action 'https://api.github.com/repos/actions/cache/tarball/e12d46a63a90f2fae62d114769bbf2a179198b5c'. Error: nodename nor servname provided, or not known (api.github.com:443)
Warning: Back off 10.69 seconds before retry.
Error: nodename nor servname provided, or not known (api.github.com:443)

@yamt
Copy link
Collaborator Author

yamt commented Jan 19, 2024

i haven't checked if something similar is necessary for windows.

wenyongh
wenyongh reviewed Jan 19, 2024
View reviewed changes
Copy link
Contributor

@wenyongh wenyongh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wenyongh wenyongh merged commit bc35602 into bytecodealliance:main Jan 19, 2024
407 checks passed
victoryang00 pushed a commit to victoryang00/wamr-aot-gc-checkpoint-restore that referenced this pull request May 27, 2024
@yamt
Fix aot large model (--size-level=0) with LLVM 18 (bytecodealliance#3057
2ce088e 
)

The recent versions LLVM uses ".ltext" section for X86 large model.

cf. llvm/llvm-project@d8a0439

This fixes bytecodealliance#3034
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wenyongh wenyongh wenyongh left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LLVM 18: large model (--size-level=0) is broken
2 participants
@yamt @wenyongh