Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check ValueKind before extracting constant int value #2595

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

lum1n0us
Copy link
Collaborator

No description provided.

@lum1n0us lum1n0us force-pushed the check_constant_value_kind branch from f628ee0 to 74e928c Compare September 26, 2023 23:19
Copy link
Contributor

@wenyongh wenyongh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wenyongh wenyongh merged commit cd0cec5 into bytecodealliance:main Sep 28, 2023
victoryang00 pushed a commit to victoryang00/wamr-aot-gc-checkpoint-restore that referenced this pull request May 27, 2024
…nce#2595)

Only when the value kind is LLVMConstantIntValueKind and the value
is not undef and not poison can we extract the value of a constant int.

Fixes bytecodealliance#2557 and bytecodealliance#2559.
@lum1n0us lum1n0us deleted the check_constant_value_kind branch May 31, 2024 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants