Skip to content

Conversation

@yamt
Copy link
Collaborator

@yamt yamt commented Sep 20, 2023

On posix-like platforms, the rest of wasi-threads tests should pass after the recent changes including the following PRs:

#2516 #2524 #2529

@yamt
Copy link
Collaborator Author

yamt commented Sep 20, 2023

i will take a look at failures later

@yamt yamt marked this pull request as draft September 20, 2023 10:30
@loganek
Copy link
Collaborator

loganek commented Sep 20, 2023

FYI: #2484

@yamt
Copy link
Collaborator Author

yamt commented Sep 21, 2023

i will take a look at failures later

a fix: #2571

@yamt
Copy link
Collaborator Author

yamt commented Sep 21, 2023

FYI: #2484

the PR seems to change too many things for my purpose.

@yamt yamt force-pushed the update-wasi-testsuite branch from b864a73 to 5d3e6a2 Compare September 21, 2023 04:01
@yamt yamt marked this pull request as ready for review September 21, 2023 04:01
@yamt yamt marked this pull request as draft September 21, 2023 05:16
@yamt
Copy link
Collaborator Author

yamt commented Sep 21, 2023

see also: #2576

@yamt yamt force-pushed the update-wasi-testsuite branch from 5d3e6a2 to c266243 Compare September 22, 2023 03:11
@yamt
Copy link
Collaborator Author

yamt commented Sep 22, 2023

see also #2582

On posix-like platforms, the rest of wasi-threads tests
should pass after the recent changes including the following PRs:

bytecodealliance#2516
bytecodealliance#2524
bytecodealliance#2529
@yamt yamt force-pushed the update-wasi-testsuite branch from c266243 to bdf26b9 Compare September 23, 2023 03:30
@yamt yamt marked this pull request as ready for review September 23, 2023 03:44
@wenyongh
Copy link
Contributor

@loganek is this PR good to you? Should we merge it?

@wenyongh
Copy link
Contributor

@loganek is this PR good to you? Should we merge it?

Just found you mentioned the similar change in #2484, so let's merge this PR first.

@wenyongh wenyongh merged commit 94f276e into bytecodealliance:main Sep 26, 2023
@loganek
Copy link
Collaborator

loganek commented Sep 26, 2023

@wenyongh sorry for late reply, I'm currently on holidays. Thanks for merging the PR

vickiegpt pushed a commit to vickiegpt/wamr-aot-gc-checkpoint-restore that referenced this pull request May 27, 2024
On posix-like platforms, the rest of wasi-threads tests
should pass after the recent changes including the following PRs:
bytecodealliance#2516, bytecodealliance#2524, bytecodealliance#2529, bytecodealliance#2571, bytecodealliance#2576 and bytecodealliance#2582.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants