Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dead lock in source debugger #2040

Merged
merged 1 commit into from
Mar 20, 2023

Conversation

xujuntwt95329
Copy link
Collaborator

No description provided.

@xujuntwt95329 xujuntwt95329 marked this pull request as ready for review March 19, 2023 04:41
@xujuntwt95329
Copy link
Collaborator Author

@eloparco This PR is based on your previous one: #1991
Could you help review it?

Thanks

@eloparco
Copy link
Contributor

I ran the main branch locally and I could see the problem, with the lock already acquired in

os_mutex_lock(&exec_env->wait_lock); \
and then again in wasm_cluster_thread_waiting_run.

I hadn't tried the debugger since that PR so I didn't notice. Unfortunately, I don't think there is any simple way to automatically detect similar issues in the CI.

Copy link
Contributor

@eloparco eloparco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xujuntwt95329
Copy link
Collaborator Author

@eloparco Thanks a lot!
Yes, there seems not an easy way to validate source debugger in CI.
A possible approach may be using lldb scripts, which can execute some commands without terminal input, the problem is how to validate the result of every command.

@wenyongh wenyongh merged commit d75cb32 into bytecodealliance:main Mar 20, 2023
victoryang00 pushed a commit to victoryang00/wamr-aot-gc-checkpoint-restore that referenced this pull request May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants