Make a workaround when fstat() return NOT_SUPPORT
#1970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lum1n0us
force-pushed
the
if_not_support_fstat
branch
3 times, most recently
from
8b0ea34 to
1f9c4ab
Compare
wenyongh
reviewed
Feb 20, 2023
core/iwasm/libraries/libc-wasi/sandboxed-system-primitives/src/posix.c
Outdated
Show resolved
Hide resolved
core/iwasm/libraries/libc-wasi/sandboxed-system-primitives/src/posix.c
Outdated
Show resolved
Hide resolved
The problem was found by a Golang + WAMR(as CGO) wrapped by EGO in a SGX Enclave. `fstat()` in EGO returns dummy values. FYI: - EGO use a `mount` configuration to define mount points that apply the host file system presented to the encalve. - EGo has a different programming model: The entire application runs inside the enclave. Manual ECALLs/OCALLs by application code are neither required nor possible. Now, it is able to specify EGO platform via the CLI: `$ cmake -S . -B build -DWAMR_BUILD_PALTFORM=ego`
lum1n0us
force-pushed
the
if_not_support_fstat
branch
from
1f9c4ab to
6d89539
Compare
victoryang00
pushed a commit
to victoryang00/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
…iance#1970) The problem was found by a `Golang + WAMR (as CGO)` wrapped by EGO in SGX Enclave. `fstat()` in EGO returns dummy values: - EGO uses a `mount` configuration to define the mount points that apply the host file system presented to the Encalve. - EGO has a different programming model: the entire application runs inside the enclave. Manual ECALLs/OCALLs by application code are neither required nor possible. Add platform ego and add macro control for the return value checking of `fd_determine_type_rights` in libc-wasi to resolve the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was found by a Golang + WAMR(as CGO) wrapped by EGO in a SGX Enclave.
fstat()in EGO returns dummy values.FYI:
EGO use a
mountconfiguration to define mount points that apply the host file system presented to the encalve.EGo has a different programming model: The entire application runs inside the enclave. Manual ECALLs/OCALLs by application code are neither required nor possible.