Loosen the wasi abi compatibility check in loader #1932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenyongh
changed the title
victoryang00
pushed a commit
to victoryang00/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
) Change an error to warning when checking wasi abi compatibility in loader, for rust case below: #[no_mangle] pub extern "C" fn main() { println!("foo"); } compile it with `cargo build --target wasm32-wasi`, a wasm file is generated with wasi apis imported and a "void main(void)" function exported. Other runtime e.g. wasmtime allows to load it and execute the main function with `--invoke` option.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change an error to warning when checking wasi abi compatibility in loader, for rust case below:
#[no_mangle]
pub extern "C" fn main() {
println!("foo");
}
compile it with
cargo build --target wasm32-wasi, a wasm file is generated with wasi apis importedand a "void main(void)" function exported.
Other runtime e.g. wasmtime allows to load it and execute the main function with
--invokeoption.