Fix/nuttx spectest option and symbols #1687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NuttX doesn't have SO_REUSEPORT.
Register some symbols and enable the WASM_ENABLE_SPEC_TEST for nuttx
…ion_for_nuttx' into local_main
wenyongh
reviewed
Nov 8, 2022
core/iwasm/aot/aot_reloc.h
Outdated
Comment on lines
139
to
140
| REG_SYM(sqrt), \ | ||
| REG_SYM(sqrtf), \ |
There was a problem hiding this comment.
sqrt/sqrtf might be a macro but not function, adding them here may cause compile error, see Windows CI report:
https://github.com/bytecodealliance/wasm-micro-runtime/actions/runs/3406870901
Suggest to register them like aot_memset/memmove:
Declare and implement aot_sqrt and aot_sqrtf in aot_runtime.h and aot_runtime.c, just after the code of aot_memset and aot_memmove:
https://github.com/bytecodealliance/wasm-micro-runtime/blob/main/core/iwasm/aot/aot_runtime.h#L448-L452
And here:
{ "sqrt", (void*)aot_sqrt },
{ "sqrtf", (void*)aot_sqrtf },There was a problem hiding this comment.
Thanks. then how can we know which APIs may not function but macro? if in future we encounter similar problems again
…indows platform sqrt and sqrtf cannot be a const value to init struture instance on windows platform
NingW101
pushed a commit
to NingW101/wasm-micro-runtime
that referenced
this pull request
Dec 1, 2022
…nce#1687) Enable spec test option on Nuttx platform. Register sqrt/sqrtf in aot global symbol map and _fixdfdi/__floatundidf in xtensa symbol map.
wenyongh
pushed a commit
that referenced
this pull request
Dec 6, 2022
Enable spec test option on Nuttx platform. Register sqrt/sqrtf in aot global symbol map and _fixdfdi/__floatundidf in xtensa symbol map.
victoryang00
pushed a commit
to victoryang00/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
…nce#1687) Enable spec test option on Nuttx platform. Register sqrt/sqrtf in aot global symbol map and _fixdfdi/__floatundidf in xtensa symbol map.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable spec test option on nuttx platform
Register more symbols in sym_map