Implement http_body::Body and some useful conversions #126
Conversation
|
I think this is really excellent work and something the ecosystem really needs. And I'm really glad that with p3 it can land directly in the wasi-rs crate instead of needing wstd! |
|
The only thing I'd add over what others already said is it might be good to have something at |
fibonacci1729
force-pushed
the
wasip3-http-ext
branch
4 times, most recently
from
b330ab8 to
9935f30
Compare
…e conversions Signed-off-by: Brian Hardock <brian.hardock@fermyon.com>
fibonacci1729
force-pushed
the
wasip3-http-ext
branch
from
9935f30 to
6bb91a3
Compare
|
Added an example and addressed all the comments. This is ready for another/final review! |
Signed-off-by: Brian Hardock <brian.hardock@fermyon.com>
|
Oh, actually, right after hitting merge I realized -- I don't think that this is built on CI just yet, so could you update CI configs to ensure that the wasip3 crate is built with this feature? Right now we don't run any wasip3 things due to when CI was added Wasmtime didn't have support, and we could add support for that now too but I can take care of that later. |
Mostly get a crates.io release with bytecodealliance#126
* Bump wasip3 to 0.2.1 Mostly get a crates.io release with #126 * Update generated code
4 participants
This PR provides an implementation of
http_body::Bodywhich enables a pretty seamless interoperability story with the Rust HTTP ecosystem. Additionally implemented are some useful translations to convert between items inwasip3::http::typesand types part of thehttppackage.Any early feedback / guidance on how to best structure this integration would be extremely appreciated!