Parse the deployment target on all Apple target triples #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also allow it to be optional, or partially specified.
To more easily determine if the OS is of Darwin lineage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also allow it to be optional, or partially specified.
This is a breaking change.
I've chosen to keep
Darwinas a separate OS, since it seems like in #111 (comment) that this crate wants to focus on LLVM target triples.Another solution would've been to merge it into
OperatingSystem::MacOSX, and just ignore that"darwin"doesn't technically mean that (though it is likely to in practice). If we chose this solution (which would be focusing more onrustctargets), I would probably not want to parse the version at all, and just ignore it instead.