Be #1472
Be #1472
Conversation
|
@sunfishcode Grateful for your thoughts on this. |
|
Seems the A few of the other commits also adress issues caused by the release of new crates which require a version of rust higher than the MSRV. Lastly, there is a commit to fix an issue whereby constants guarded by the |
| # the same consistent version. We therefore need to use a version of tempfile | ||
| # for which its rustix dependency is a semver match for our current version. | ||
| [patch.crates-io] | ||
| rustix = { path = "." } |
There was a problem hiding this comment.
This will make it impossible to do a semver incompatible release of rustix as there is no tempfile version that has a semver compatible dependency on rustix yet.
There was a problem hiding this comment.
I can't really see a good solution to this problem. I guess the real problem is that there is a cyclic dependency, but the two projects are both under separate ownership. The only clean solution I can see is to remove that dependency and trty to find an alternative crate. The change is outside the scope of my original PR really, I just wanted to try and get the CI working to ensure I didn't introduce any regressions. But it seems unfortunately that new releases of other crates change the result of the CI. Happy to take advice on how to proceed here.
There was a problem hiding this comment.
One option would be to keep the big-endian CI disabled for now and only enable it once there is a new rustix release.
There was a problem hiding this comment.
tempfile's use of rustix is not part of rustix's testsuite. We don't need to make tempfile's version of rustix match the version of rustix using tempfile for tests. They can differ and it's fine.
| @@ -286,11 +286,11 @@ pub(crate) const SIGSYS: c_int = linux_raw_sys::general::SIGSYS as _; | |||
| ))] | |||
| pub(crate) const SIGEMT: c_int = linux_raw_sys::general::SIGEMT as _; | |||
|
|
|||
| #[cfg(feature = "stdio")] | |||
| #[cfg(any(test, feature = "stdio"))] | |||
|
@bjorn3 Thanks for the feedback. Just let me know how best to proceed and I'm happy to make any changes. |
rustixto use thelinux_rawbackend onarmeb-unknown-linux-gnueabiandaarch64_be-unknown-linux-gnutargets. (Both of these are tier 3 rust platforms and hence no public binaries are provided).rustixusestempfilefor its unit test, which in turn usesrustixas a dependency we have a cyclic dependency. Change theCargo.tomlso that the version ofrustixused to satisfy thistempfiledependency is the working copy.