This repository was archived by the owner on Mar 24, 2022. It is now read-only.
Repository navigation
Conversation
added 2 commits
September 10, 2019 16:25
and add cranelift-object and object to the project
unfortunately, though pretty close to the same, the trap sink interfaces for object and faerie are not compatible, so we're going to be stuck with this intermediate type for the time being
pchickey
force-pushed
the
pch/object_by_default
branch
from
September 12, 2019 18:10
3847b4b to
f74e011
Compare
Contributor
Author
|
I need to set this PR aside for a while, other stuff is higher priority at the moment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Taking a different approach to #271 to mitigate risk:
Rather than translating all use of Faerie to Object, this PR makes it a runtime selection between the two, defaulting to Object.
WIP- still trying to divide between the two backends on the right line