Skip to content

wit, wit/bindgen: fix handling of transitively included @since gates across package boundaries #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
May 7, 2025

Conversation

ydnar
Copy link
Collaborator

@ydnar ydnar commented Mar 23, 2025

Fixes #325.

@vados-cosmonic
Copy link
Contributor

Hey @ydnar just to pop in here and keep you up to date, error-contexts are going to be removed from implementations for stream/future but will continue to exist (and be evolved down the road) for general use:

WebAssembly/component-model#477
(barring of course some intense breakdown of consensus)

Hopefully this eases implementation that you're already working on! We also have some WAST tests and Rust tests w/ components that might be useful for reference.

@ydnar
Copy link
Collaborator Author

ydnar commented Mar 24, 2025

Can we rename it to just error?

@vados-cosmonic
Copy link
Contributor

What immediately comes to mind is that error would become a reserved name and then %error would be required in many places and up and breaking WITs... The other thing that might stand in the way is that the error-context is not actually the error (and won't be for some time -- if ever), it's more information related to the error than anything else (though I would personally hope we can pass around data in there somehow, someday).

I think it's certainly worth discussing in that thread though -- I don't know exactly why it wasn't called error in the first place, but I assume there are good reasons.

@ydnar ydnar force-pushed the ydnar/issue325 branch from 79fe4f7 to 29e126b Compare May 6, 2025 22:14
@ydnar ydnar marked this pull request as ready for review May 7, 2025 00:02
@ydnar ydnar self-assigned this May 7, 2025
@ydnar ydnar merged commit 479262c into main May 7, 2025
13 checks passed
@ydnar ydnar deleted the ydnar/issue325 branch May 7, 2025 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@since gates should not transitively apply across package boundaries when worlds are included
2 participants