Skip to content
This repository was archived by the owner on Jun 26, 2020. It is now read-only.

Add cranelift-object - #937

Merged
sunfishcode merged 1 commit into
bytecodealliance:masterfrom
philipc:object
Sep 10, 2019
Merged

sunfishcode merged 1 commit into
bytecodealliance:masterfrom
philipc:object

Conversation

@philipc

@philipc philipc commented Aug 25, 2019

Copy link
Copy Markdown
Contributor

Fixes #761

Comment thread cranelift-object/src/backend.rs Outdated
Comment thread cranelift-object/src/backend.rs Outdated
Comment thread cranelift-object/src/backend.rs

@sunfishcode sunfishcode left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really nice!

I attempted to update the crate versions to fix the CI, however we have a target-lexicon version conflict. I submitted gimli-rs/object#126 to update object to match the version currently used in cranelift. Once that's straightened out, this looks good to go!

@philipc

philipc commented Sep 8, 2019

Copy link
Copy Markdown
Contributor Author

I'll make a new object release and update this PR once gimli-rs/object#127 is sorted.

@bnjbvr

bnjbvr commented Sep 9, 2019

Copy link
Copy Markdown
Member

(Please don't add merge commits to PRs, if that's possible. We've been trying really hard to have a linear history, and to rebase everything on top of previous work, so as to avoid merge commits and make bisection trivial. It's a small price to pay off for better debugging.)

@philipc

philipc commented Sep 9, 2019

Copy link
Copy Markdown
Contributor Author

When I rebase, should I squash 38d0289 so that the history is bisectable?

@bnjbvr

bnjbvr commented Sep 9, 2019

Copy link
Copy Markdown
Member

Ideally, commits would be atomic, do one thing and keep on passing all the tests (that's really best effort, compared to the strong requirement of not having merge commits). If this matches this criteria, it's fine to keep it separated in my opinion. (We should probably agree on these conventions and put them in the CONTRIBUTING.md file at some point.)

@philipc

philipc commented Sep 9, 2019

Copy link
Copy Markdown
Contributor Author

CONTRIBUTING.md actually does pretty much say that already :)

@philipc

philipc commented Sep 10, 2019

Copy link
Copy Markdown
Contributor Author

Rebased and squashed.

@sunfishcode

Copy link
Copy Markdown
Member

Thanks!

@sunfishcode
sunfishcode merged commit ea28344 into bytecodealliance:master Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Alternative object file backend

4 participants