Skip to content

Conversation

catamorphism
Copy link
Contributor

I tried to define some undefined terms, and verified the commands and their output.

I tried to define some undefined terms, and verified the commands and their output.
Copy link
Collaborator

@vados-cosmonic vados-cosmonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update and run through the C docs @catamorphism !

catamorphism and others added 27 commits August 6, 2025 12:46
Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>
Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>
Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>
Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>
Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>
Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>
Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>
Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>
Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>
Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>
Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>
Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>
Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>
Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>
Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>
Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>
Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>
Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>
Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>
Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>
Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>
Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>
Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>
Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>
Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>
catamorphism and others added 3 commits August 6, 2025 13:01
Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>
Copy link
Collaborator

@vados-cosmonic vados-cosmonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Thanks for making these changes @catamorphism -- at this point I think once we have some input from others on the including-example-code-in-the-repo issue and the other stuff resolved we should merge this in.

If we haven't seen movement/discussion on the other stuff by monday, let's move this forward and merge.

@@ -281,7 +281,7 @@ wasm-tools component new \

## 5. Inspect the built component

Finally, you can inspect the embedded WIT to see your component
Finally, you can inspect the WIT embedded in your component
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit, so feel free to ignore, but there isnt any WIT inside the component, so embedded is the wrong verb here and might create a misconception. The component itself has imports and exports, the total of which can be rendered as a wit document. Maybe find a good way to word that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed in 7982cf8, let me know what you think.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to leave this open but merge in the meantime for forward progress -- obviously happy to merge a one line change to fix this in the future :)

@vados-cosmonic vados-cosmonic merged commit c420ce1 into bytecodealliance:main Aug 12, 2025
8 checks passed
catamorphism added a commit to catamorphism/component-docs that referenced this pull request Aug 12, 2025
…bytecodealliance#298)

* Revise and expand on C/C++ language support section

I tried to define some undefined terms, and verified the commands and their output.

* Update component-model/src/language-support/c.md

Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>

* Update component-model/src/language-support/c.md

Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>

* Update component-model/src/language-support/c.md

Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>

* Update component-model/src/language-support/c.md

Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>

* Update component-model/src/language-support/c.md

Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>

* Update component-model/src/language-support/c.md

Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>

* Update component-model/src/language-support/c.md

Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>

* Fix markup in NOTE

* Fix backtick spacing

* Update component-model/src/language-support/c.md

Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>

* Update component-model/src/language-support/c.md

Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>

* Update component-model/src/language-support/c.md

Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>

* Update component-model/src/language-support/c.md

Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>

* Update component-model/src/language-support/c.md

Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>

* Update component-model/src/language-support/c.md

Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>

* Update component-model/src/language-support/c.md

Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>

* Update component-model/src/language-support/c.md

Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>

* Update component-model/src/language-support/c.md

Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>

* Update component-model/src/language-support/c.md

Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>

* Update component-model/src/language-support/c.md

Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>

* Update component-model/src/language-support/c.md

Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>

* Update component-model/src/language-support/c.md

Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>

* Update component-model/src/language-support/c.md

Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>

* Update component-model/src/language-support/c.md

Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>

* Update component-model/src/language-support/c.md

Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>

* Update component-model/src/language-support/c.md

Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>

* Update component-model/src/language-support/c.md

Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>

* Update component-model/src/language-support/c.md

Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>

* Indent note about PATH

* Minor fixes

* Add comment in component_with_printf example

* Fix broken 'Add WASI to Linker' link

* Address review feedback

---------

Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants