Skip to content

chore(ci): add clippy #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

vados-cosmonic
Copy link
Contributor

Appeasing clippy is clearly not a goal, but it may be nice to have the code be a bit more consistent and enforcably so.

@tschneidereit
Copy link
Member

I'm in favor of adding a Clippy check, but let's make sure that we're judicious in which lints we enable, instead of manually overriding those we don't like in the code. We could copy the configuration from Wasmtime, for example?

@vados-cosmonic
Copy link
Contributor Author

Sure, those seem like reasonable defaults

@vados-cosmonic
Copy link
Contributor Author

vados-cosmonic commented Jul 14, 2025

Wait, actually @tschneidereit thinking about it some more -- I'm not sure we should allow then re-add. wasmtime does a lot of really advanced stuff that clippy would get noisy about but I don't think componentize-js is in the same boat. IMO the default lints should mostly be in place here with a few exceptions.

How about we allow too_many_arguments instead?

[EDIT] Change is done -- the Cargo.toml changes are in

@vados-cosmonic vados-cosmonic merged commit a2622a2 into bytecodealliance:main Jul 14, 2025
16 checks passed
@vados-cosmonic vados-cosmonic deleted the chore(ci)=add-clippy branch July 14, 2025 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants