Skip to content

Conversation

@ivicac
Copy link
Contributor

@ivicac ivicac commented Nov 25, 2025

  • 1835 Move WebhookResponse to component-api, remove the hardcoded list of supported actions returning WebhookResponse in JobSyncExecutor
  • 1835 Add upgrade process for metadata column in task_execution table

Copilot finished reviewing on behalf of ivicac November 25, 2025 08:20
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors webhook response handling by moving WebhookResponse from the platform layer to the component API layer, and introduces a more flexible mechanism for detecting webhook responses through task execution metadata instead of a hardcoded component list.

  • Moves WebhookResponse class from platform-component-api to component-api (SDK layer) with comprehensive JavaDoc documentation
  • Replaces hardcoded webhook component list with a metadata-based detection mechanism using TaskExecutionPostOutputProcessor
  • Adds a persisted metadata column to the task_execution table for storing task-level metadata

Reviewed changes

Copilot reviewed 26 out of 26 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
settings.gradle.kts Adds new platform-worker module to the build
server/libs/platform/platform-worker/* New module containing WebhookResponseTaskExecutionPostOutputProcessor for marking webhook responses in task metadata
server/libs/platform/platform-coordinator/src/main/java/com/bytechef/platform/coordinator/job/JobSyncExecutor.java Removes hardcoded WEBHOOK_COMPONENTS list and checks task metadata instead
server/libs/atlas/atlas-execution/atlas-execution-api/src/main/java/com/bytechef/atlas/execution/domain/TaskExecution.java Changes metadata from transient to persisted field using MapWrapper
server/libs/atlas/atlas-worker/atlas-worker-impl/src/main/java/com/bytechef/atlas/worker/TaskWorker.java Adds support for TaskExecutionPostOutputProcessor list to process outputs
server/libs/atlas/atlas-worker/atlas-worker-api/src/main/java/com/bytechef/atlas/worker/task/handler/TaskExecutionPostOutputProcessor.java New interface for post-processing task outputs
server/libs/atlas/atlas-worker/atlas-worker-config/src/main/java/com/bytechef/atlas/worker/config/TaskWorkerConfiguration.java Updates TaskWorker bean to inject list of post-output processors
sdks/backend/java/component-api/src/main/java/com/bytechef/component/definition/WebhookResponse.java New location for WebhookResponse with extensive JavaDoc documentation
server/libs/atlas/atlas-execution/atlas-execution-repository/atlas-execution-repository-jdbc/src/main/resources/config/liquibase/changelog/atlas/execution/202501114215080_atlas_execution_added_column_task_execution.xml Database migration to add metadata column
Multiple component files Updates imports from platform.component.definition.WebhookResponse to component.definition.WebhookResponse
Multiple test files Updates TaskWorker instantiations to include empty list for post-output processors
Multiple build.gradle.kts files Adds dependencies on new platform-worker module

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants