-
Notifications
You must be signed in to change notification settings - Fork 2
docs: improve GCP service account authentication documentation #839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Rewrite GCP Secret Manager section to use GCE VM service accounts (most secure method) - Create shared Prerequisites section for service account setup (GCE and GKE) - Consolidate to single 'bytebase' service account instead of multiple accounts - Add GKE with Workload Identity support - Remove duplicate content between Cloud SQL and Secret Manager sections - Fix IAM user creation methods (gcloud/Console, not SQL commands) - Correct username formats for MySQL and PostgreSQL - Reduce documentation wordiness by ~50% - Remove 7 obsolete screenshot images - Add comprehensive Google Cloud documentation references 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR improves GCP service account authentication documentation by prioritizing secure authentication methods and consolidating redundant content. The changes make the documentation more secure, clearer, and easier to follow.
Key changes:
- Restructured to use GCE VM service accounts as the primary authentication method instead of service account keys
- Created unified Prerequisites section that eliminates duplication between Cloud SQL and Secret Manager configurations
- Significantly reduced content length while improving clarity and removing obsolete screenshots
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
📝 Broken Links Check Report
The following is the output from the broken links check:
|
Summary
Changes
Security Improvements
Documentation Structure
bytebase
service account - simpler than managing multiple accountsTechnical Corrections
bytebase
(service account name only)bytebase@PROJECT_ID.iam
(without .gserviceaccount.com suffix)Content Improvements
Test Plan
🤖 Generated with Claude Code