EvaluteRTE: Correctly report AbortOnValue aborts with negative abort codes #500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Garados007
requested changes
Jul 24, 2025
procedures/igortest-basics.ipf
Outdated
| IUTF_Reporting#AddError(str, IUTF_STATUS_ERROR) | ||
| break | ||
| default: | ||
| if(abortCode != 0) |
There was a problem hiding this comment.
This can be optimized. Just add a case which checks for 0 and does nothing and move the content of the if statement into the default case directly.
Doing this you have one level of indentation less and no if statement.
There was a problem hiding this comment.
Good point. But thinking about this again, the dheck for non-zero abort code is not correct either. The abort code can be anything. Fill send a fixed version.
There was a problem hiding this comment.
Ok, so the -1, -2, -3 cases can possibly also be AbortOnValue then.
There was a problem hiding this comment.
Unfortunately yes. My idea here is that this is not as likely as the other abort types.
t-b
force-pushed
the
bugfix/ignored-negative-abort-on-value-values
branch
2 times, most recently
from
ebcc83c to
5d3d41a
Compare
Since 649b354 (Remove requirement of allTestCases in main loop returned by getTestCasesMatch, 2022-09-06) we don't have any parameters anymore. Probably only found now because we recently upgraded the sphinx docker image.
…codes We need to assume that all error codes not being -1, -2, -3, -4 are from AbortOnValue as we can't differentiate them. This now correctly reports AbortOnValue aborts with negative abort codes. Broken since a7ab54c (More detailed RTE error message, 2017-03-07). It did not help that the Igor Pro documentation is also wrong in this regard.
t-b
force-pushed
the
bugfix/ignored-negative-abort-on-value-values
branch
from
5d3d41a to
090eb74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to assume that all error codes not being -1, -2, -3, -4 are from AbortOnValue as we can't differentiate them. This now correctly reports AbortOnValue aborts with negative abort codes.
Broken since a7ab54c (More detailed RTE error message, 2017-03-07). It did not help that the Igor Pro documentation is also wrong in this regard.