Skip to content

Fix DP logical error. #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix DP logical error. #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions include/cppjieba/MPSegment.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ class MPSegment: public SegmentTagged {
return dictTrie_->IsUserDictSingleChineseWord(value);
}
private:
/*
void CalcDP(vector<DatDag>& dags) const {
for (auto rit = dags.rbegin(); rit != dags.rend(); rit++) {
rit->max_next = -1;
Expand All @@ -64,6 +65,33 @@ class MPSegment: public SegmentTagged {
}
}
}
*/
void CalcDP(vector<DatDag>& dags) const {
size_t size = dags.size();

for (size_t i = 0; i < size; i++) {
dags[size - i - 1].max_next = -1;
dags[size - i - 1].max_weight = MIN_DOUBLE;

for (const auto & it : dags[size - i - 1].nexts) {
const auto nextPos = it.first;
double val = dictTrie_->GetMinWeight();

if (nullptr != it.second) {
val = it.second->weight;
}

if (nextPos < dags.size()) {
val += dags[nextPos].max_weight;
}

if ((nextPos <= dags.size()) && (val > dags[size - i - 1].max_weight)) {
dags[size - i - 1].max_weight = val;
dags[size - i - 1].max_next = nextPos;
}
}
}
}
Copy link
Owner

@byronhe byronhe Apr 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

原来的实现是 for (auto rit = dags.rbegin(); rit != dags.rend(); rit++) {，也是倒序遍历，跟新加的这个是完全一样的逻辑。


void CutByDag(RuneStrArray::const_iterator begin,
RuneStrArray::const_iterator,
Expand Down