Skip to content

Conversation

@lifeimm100
Copy link

This update introduces a ping_timer attribute to the _WebSocketManager class, ensuring that the ping timer is properly canceled when closing the websocket connection.

This update introduces a ping_timer attribute to the _WebSocketManager class, ensuring that the ping timer is properly canceled when closing the websocket connection.
@dextertd
Copy link
Collaborator

dextertd commented Apr 8, 2025

The user can already control how frequently the websocket pings with the ping_interval arg. What's the benefit of exposing this ping_timer as well?

@kolya5544
Copy link
Collaborator

^ should probably be a private field

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants