Add response headers support to ServerResponse and BatchOrderServerResponse #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sponse - Add Headers field to ServerResponse struct for rate limit tracking - Add Headers field to BatchOrderServerResponse struct - Modify callAPI to return response headers - Update SendRequest to return headers - Update GetServerResponse and GetBatchOrderServerResponse to accept and populate headers - Update all API methods to pass headers through the call chain - Enables tracking rate limits from response headers in PlaceOrder, AmendOrder, CancelOrder, and batch order operations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds response headers support to
ServerResponseandBatchOrderServerResponsestructs to enable rate limit tracking from API responses.Changes
Headers http.Headerfield toServerResponsestructHeaders http.Headerfield toBatchOrderServerResponsestructcallAPIto return response headersSendRequestto return headersGetServerResponseandGetBatchOrderServerResponseto accept and populate headersUse Case
This enables tracking rate limits from response headers in methods like
PlaceOrder,AmendOrder,CancelOrder, and batch order operations.Example usage:
resp, err := client.PlaceOrder(ctx, opts...)
rateLimitRemaining := resp.Headers.Get("X-RateLimit-Remaining")## Testing