Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add files to MessageEdit #1253

Merged
merged 2 commits into from
Oct 7, 2022
Merged

Add files to MessageEdit #1253

merged 2 commits into from
Oct 7, 2022

Conversation

ShadiestGoat
Copy link
Contributor

This PR adds the ability to edit the attachments of a message, following the discord API.

@ShadiestGoat
Copy link
Contributor Author

Forgot to mention: solves #1252

@FedorLap2006 FedorLap2006 linked an issue Sep 30, 2022 that may be closed by this pull request
message.go Outdated Show resolved Hide resolved
Co-authored-by: Fedor Lapshin <fe.lap.prog@gmail.com>
@ShadiestGoat
Copy link
Contributor Author

@FedorLap2006 you're right, I changed it now

Copy link
Collaborator

@FedorLap2006 FedorLap2006 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Though removing attachments won't work for now, since the MultipartBodyWithJSON encodes files a bit incorrectly.
I'll probably submit a fix for it soon.

@ShadiestGoat
Copy link
Contributor Author

I don't want to be "that guy", but would it be possible to know a possible timeline for this to be merged?

@FedorLap2006 FedorLap2006 merged commit 410cf4f into bwmarrin:master Oct 7, 2022
@FedorLap2006
Copy link
Collaborator

Thanks for your contribution!

LWCoder pushed a commit to AtTheTavern/discordgo that referenced this pull request Apr 11, 2023
* Add files to MessageEdit

* Remove files from json

Co-authored-by: Fedor Lapshin <fe.lap.prog@gmail.com>

Co-authored-by: Fedor Lapshin <fe.lap.prog@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support attatchments in message edits
2 participants