Support for passing event objects thru to various event handlers #605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
I don't object to passing through the event object as a new named parameter, but I do object to the name chosen. (I don't like abbreviated names. They're too arbitrary.) If you'll rename the parameter to I'd also love it if you updated any relevant documentation to list the new parameter. 😄 |
Owner
|
FYI I'm going to make my own edit and merge this. Thanks~ |
bvaughn
approved these changes
Mar 4, 2017
bvaughn
reviewed
Mar 4, 2017
| const onKeyDown = (event) => { | ||
| if (event.key === 'Enter' || event.key === ' ') { | ||
| onClick() | ||
| onClick(event) |
Owner
There was a problem hiding this comment.
This is a bit weird- though I understand why you did it. I guess it's okay since people can ignore the event or check its type
Owner
|
Merged! |
Contributor
Author
|
Thanks Brian! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So in addition to the change we made to support horizontal scrolling, we also added support for passing event objects thru the various event handlers, particularly in defaultCellRenderer. Yes, we can (and did) build our own cellRenderer to accomodate passing these event objects thru (which we needed to check the CTRL and ALT key state for some behaviors we were looking at add), but it seemed to me that it would be nice if the default renderer passed these thru.