Skip to content

Conversation

@TrySound
Copy link
Contributor

Before #994 I want to tweak babel config a bit

  • remove babel-plugin-react-transform which seems useless right now. redbox doesn't work and catching errors is not necessary with error boundaries.
  • replaced stage-1 with stage-2 preset
  • refactored .babelrc with js preset. It's now two times smaller.

@bvaughn how comments: false in babel config affect code? I saw it reduces somehow umd size about 50kb

@TrySound TrySound requested a review from bvaughn February 25, 2018 15:31
@TrySound TrySound force-pushed the refactor-babel-config branch from 7cdc9af to efdb1dc Compare February 25, 2018 15:32
@codecov-io
Copy link

codecov-io commented Feb 25, 2018

Codecov Report

Merging #1019 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1019   +/-   ##
======================================
  Coverage    90.2%   90.2%           
======================================
  Files          59      59           
  Lines        1675    1675           
======================================
  Hits         1511    1511           
  Misses        164     164

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e775173...d4fe240. Read the comment docs.

@bvaughn
Copy link
Owner

bvaughn commented Feb 28, 2018

@bvaughn how comments: false in babel config affect code? I saw it reduces somehow umd size about 50kb

I don't understand what you're asking.

@TrySound
Copy link
Contributor Author

Never mind, just confused a bit.

@bvaughn
Copy link
Owner

bvaughn commented Feb 28, 2018

Okay 😄

I don't have any problems with this change, although I haven't had the time to do a before and after comparison between this and what's in master to make sure it doesn't cause any problems in the build.

If you've done that, then feel free to merge.

@TrySound TrySound merged commit 0748c2a into master Feb 28, 2018
@TrySound TrySound deleted the refactor-babel-config branch February 28, 2018 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants