Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #17 #29

Merged
merged 2 commits into from
Jan 3, 2019
Merged

Issue #17 #29

merged 2 commits into from
Jan 3, 2019

Conversation

toleressea
Copy link
Contributor

No description provided.

@bvarga
Copy link
Owner

bvarga commented Dec 10, 2018

Is this compiling in delphi, or just in FreePascal?

@toleressea toleressea force-pushed the issue17 branch 2 times, most recently from 210384d to 476c05f Compare December 10, 2018 20:30
@toleressea
Copy link
Contributor Author

That's my bad. I just pushed some corrections that aren't FPC specific, sorry!

@toleressea
Copy link
Contributor Author

Ugh, actually I don't think that's any better. Standby...

@bvarga
Copy link
Owner

bvarga commented Dec 10, 2018

no worries :)

@toleressea
Copy link
Contributor Author

toleressea commented Dec 10, 2018

What version of Delphi are you looking for compatibility in? From what I can tell, UInt64 (equivalent to FPC's QWord) wasn't available in Delphi 7, which unfortunately is my local Delphi environment. I could use an Int64 instead, which also works. Thoughts?

Edit: And I just answered my own question by reading the docs, Delphi 7+...

@toleressea
Copy link
Contributor Author

Since it works in both FPC and Delphi, and it doesn't need to be unsigned to resolve the issue, I went with an Int64. I also limited the scope of my compilation fix to FPC only.

@toleressea
Copy link
Contributor Author

@bvarga - Are you waiting on me?

@bvarga
Copy link
Owner

bvarga commented Jan 3, 2019

No, just forgot it, will merge it.

@bvarga bvarga merged commit bcdef1f into bvarga:master Jan 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants