fix: byte as argument for string conversion (#27)

.gitignore

@@ -4,7 +4,7 @@ bin/*
 dist/*
 tmp/*
 out*
-new_funcs*
+sandbox*
 demo*
 .task*
 .ipynb*

Makefile

@@ -2,7 +2,7 @@
 export PATH   := $(PWD)/bin:$(PATH)                    # ./bin to $PATH
 export SHELL  := bash                                  # Default Shell
 
-GOPKGS := $(shell go list ./... | grep -vE "(cmd|examples|plugin|testdata|backup)" | tr -s '\n' ',' | sed 's/.\{1\}$$//' )
+GOPKGS := $(shell go list ./... | grep -vE "(cmd|sandbox|testdata)" | tr -s '\n' ',' | sed 's/.\{1\}$$//' )
 
 
 build:
@@ -33,7 +33,7 @@ test-generate:
 	go run ./cmd/internal/generate-tests/ "$(PWD)/testdata"
 
 lints:
-	golangci-lint run --no-config ./... -D deadcode --skip-dirs "^(cmd|plugin|examples|testdata)"
+	golangci-lint run --no-config ./... -D deadcode --skip-dirs "^(cmd|sandbox|testdata)"
 
 
 cover:

Taskfile.yml

@@ -10,7 +10,7 @@ tasks:
     - make build
     - make build-race
     - task: lints
-    - make test-generate
+    # - make test-generate
     - task: tests
     - cmd: go run ./cmd/mirror/ --with-tests --with-debug ./demo
       ignore_error: true

internal/checker/checker.go

@@ -77,7 +77,13 @@ func (c *Checker) Handle(v *Violation, ce *ast.CallExpr) (map[int]ast.Expr, bool
 		}
 
 		// wrong argument type
-		if v.Targets == c.Type(call.Args[0]) {
+		typeOf := c.Type(call.Args[0])
+		if typeOf != Strings && typeOf != Bytes {
+			// rune or byte in string argument
+			continue
+		} else if v.Targets == typeOf {
+			// same type like string("string") <- this is bad, but other linters
+			// (like unconvert) can handle it
 			continue
 		}
 
@@ -91,7 +97,6 @@ func (c *Checker) callConverts(ce *ast.CallExpr) bool {
 	switch ce.Fun.(type) {
 	case *ast.ArrayType, *ast.Ident:
 		res := c.Type(ce.Fun)
-
 		return res == "[]byte" || res == "string"
 	}
 

testdata/issue-26.go

@@ -0,0 +1,17 @@
+package main
+
+import (
+	"fmt"
+	"strings"
+)
+
+func foobar_byte() {
+	var strBuilder strings.Builder
+	var text string = "text"
+	var b byte = text[0]
+
+	fmt.Printf("%T\n", b)
+
+	strBuilder.WriteString(string(b))
+	fmt.Println(strBuilder.String())
+}