Add support for prometheus metrics#4
Merged
danielmcgrath merged 2 commits intomasterfrom Aug 17, 2017
Merged
Conversation
This change introduces support for exposing an HTTP endpoint for Prometheus to scrape on a simple webserver, and abstracts away the actual logging of metrics behind a discrete Instrumenter interface.
mikeybtn
approved these changes
Aug 17, 2017
README.md
Outdated
| * `STATSD_PORT`: Port of statsd server (no default); | ||
| * `STATSD_PREFIX`: Optional prefix to use with statsd metrics (no default). | ||
| * `STATSD_USE_TCP`: If non-empty, use tcp instead of udp (no default). | ||
| * `PROMETHEUS_HTTP_PORT`: Port to serve prometheus metrics from (no default). |
Contributor
There was a problem hiding this comment.
We might find other uses for the HTTP service beyond prometheus, so minor suggestion to refer to this as something more general (eg HTTP_SERVICE_PORT).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change introduces support for exposing an HTTP endpoint for Prometheus to scrape on a simple webserver, and abstracts away the actual logging of metrics behind a discrete Instrumenter interface.