Performance updates #197
Merged
Performance updates #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After doing some analysis I noticed that over 50% of CPU time was wasted on number formatting for displaying progress and download speed on UI. This minor updates will make things much faster and improve performance of the app.
Along with VLC update done in few releases back video playing us much smoother. One thing that is still missing is to show progress bar when when video is not being downloaded fast enough. That should be handled with #142.
This update should make things better for errors like popcorn-official#295, popcorn-official#284, ... when it makes it to popcorn.