Return cards and atoms from high-level insert methods #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Useful for getting a handle on inserted elements without having to drop to lower level postEditor methods.
|
Seems reasonable, FF failed on Sauce and I've kicked it |
|
Sauce still finicky, I kicked it again |
|
investigating why tests in FF @ Sauce failed. Runs fine locally. |
|
There's an issue with FF at Sauce where it doesn't properly focus the editor element in some situations. I can't reproduce it locally, but adding a line to force a selection in the thanks @joshfrench ! |
|
released in v0.9.8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It can be useful to get a handle on newly inserted cards/atoms. Currently the only way to do that is to drop to the lower-level
postEditormethods. This keeps the convenience of high-level insert behavior (range detection, nested/blank sections, &c) while enabling additional operations on the inserted element.