ci: restrict GITHUB_TOKEN to contents:read (fixes CodeQL alert #2)#12
Merged
Conversation
Fixes CodeQL code scanning alert #2 — the CI workflow job lacked an explicit permissions block, which could allow the default GITHUB_TOKEN to have broader write access than needed. This job only checks out code, so contents:read is the minimum required. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
permissions: contents: readto thetestjob in.github/workflows/ci.ymlWhy
CodeQL code scanning alert #2 flagged that the CI workflow had no explicit
permissionsblock, meaning the job inherited whatever the repository or organization default is (historically read-write for repos created before Feb 2023). This violates the principle of least privilege.The
testjob only checks out code and runs CMake/CTest — it never writes to the repo, creates releases, or interacts with issues/PRs — socontents: readis the minimum sufficient permission.Reviewer notes
No behavioral change to the CI run itself; this is a security hygiene fix only.
🤖 Generated with Claude Code