fix: add explicit read-all permissions to CI workflow#13
Merged
Conversation
Resolves CodeQL alert #2 (Medium) — workflow did not declare permissions, which means it implicitly inherits write-all repo defaults and could allow compromised actions to exfiltrate secrets or modify repo state. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Added
permissions: read-allat the top-level of.github/workflows/ci.yml.Why
CodeQL flagged this as alert #2 (Medium severity): Workflow does not contain permissions. Without an explicit
permissionsblock, GitHub Actions workflows inherit the repository's default token permissions — typicallywrite-all. A compromised or malicious third-party action in the job could then useGITHUB_TOKENto push code, create releases, modify issues, or read secrets it shouldn't have access to.Declaring
permissions: read-allenforces least-privilege: this CI job only needs to check out and read the repository, so no write access is required.Reviewer notes
permissionsblock on that specific job rather than widening the top-level grant.🤖 Generated with Claude Code