Knight minimum steps chess#2
Merged
Merged
Conversation
bushidocodes
requested changes
Mar 14, 2019
bushidocodes
left a comment
bushidocodes
left a comment
Owner
There was a problem hiding this comment.
Let me know if you have any questions. I'll need to re-review once these are addressed because I don't yet funny understand the algorithm yet.
OutOfBounds function renamed from outOfBoard. Return -1 value if OutOfBounds start/goal. Return 0 value if knight is in the goal position. Return number of steps for the rest of scenarios. Use isInsideLimits to dry up the code. Use JUnit assertions for testing Name the test functions in a more verbose way. Rename setupBoard to startGame
2 tasks
bushidocodes
added a commit
that referenced
this pull request
Jun 20, 2026
Adds an explicit `permissions: contents: read` block to satisfy the principle of least privilege and resolve CodeQL alert #2. Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.