Skip to content

Comments

feat: add -config.check flag for configuration validation#745

Merged
burningalchemist merged 2 commits intoburningalchemist:masterfrom
deferraz:feature/check_configuration_flag
May 7, 2025
Merged

feat: add -config.check flag for configuration validation#745
burningalchemist merged 2 commits intoburningalchemist:masterfrom
deferraz:feature/check_configuration_flag

Conversation

@deferraz
Copy link
Contributor

@deferraz deferraz commented May 6, 2025

Introduce a new command-line flag to validate the configuration before starting the SQL exporter.

This Flag could be used to validate main configuration yaml and possible collector ones in a github-action pipeline before deployment

@burningalchemist
Copy link
Owner

Hey @deferraz, thanks for your contribution!

I planned to make a sophisticated validator with some hints on the errors and so on, but I think the simple solution makes total sense for now. 👍

One small remark: do you mind changing the flag name to config.check? I know the notation is not ideal, but it'd be easier to refactor it later, when we come close to v1.0. 😃👍

@deferraz
Copy link
Contributor Author

deferraz commented May 7, 2025

Sure @burningalchemist I've included your sugestion in 8ad8e9b

@burningalchemist burningalchemist changed the title Add -check-config flag for configuration validation feat: add -config.check flag for configuration validation May 7, 2025
@burningalchemist burningalchemist merged commit 92d2102 into burningalchemist:master May 7, 2025
4 checks passed
@deferraz deferraz deleted the feature/check_configuration_flag branch May 7, 2025 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants