Skip to content

Comments

feat(helm): add support for initContainers on the chart#731

Merged
burningalchemist merged 4 commits intoburningalchemist:masterfrom
brunomanzo:feat/add-init-containers-support
Apr 22, 2025
Merged

feat(helm): add support for initContainers on the chart#731
burningalchemist merged 4 commits intoburningalchemist:masterfrom
brunomanzo:feat/add-init-containers-support

Conversation

@brunomanzo
Copy link
Contributor

Kubernetes 1.29+ now supports sidecars containers: https://kubernetes.io/docs/concepts/workloads/pods/sidecar-containers/

Add support initContainers as a field on the chart.

@burningalchemist
Copy link
Owner

burningalchemist commented Apr 22, 2025

Hey @brunomanzo, thanks for your contribution!

Do you have any particular ideas on how initContainers might be used in the sql_exporter helm chart? I believe users might find it useful.

Also, please make sure to check Dev Notes (https://github.com/burningalchemist/sql_exporter/tree/master/helm#dev-notes).

The version in Chart.yaml also needs a bump up. Not sure if it's a backward-compatible change, so it might be 0.12.

@brunomanzo
Copy link
Contributor Author

@burningalchemist Ah, my bad, I will fix it

Currently I am using with cloud-sql-proxy as a sidecar, it could be used in the extraContainers but since kuberentes 1.29 we are using the initContainers for such container.

@burningalchemist
Copy link
Owner

@brunomanzo Cool, sounds good to me! 🙌

@burningalchemist
Copy link
Owner

@brunomanzo, apologies, the version should be semantically correct, so it's 0.12.0. 👍

@burningalchemist burningalchemist changed the title feat: add support for initContainers on the chart feat(helm): add support for initContainers on the chart Apr 22, 2025
@burningalchemist
Copy link
Owner

🚀

@burningalchemist burningalchemist merged commit edcb4f9 into burningalchemist:master Apr 22, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants