fix(helm): ServiceMonitor namespace override#563
Merged
burningalchemist merged 4 commits intoburningalchemist:masterfrom Jul 19, 2024
Merged
fix(helm): ServiceMonitor namespace override#563burningalchemist merged 4 commits intoburningalchemist:masterfrom
burningalchemist merged 4 commits intoburningalchemist:masterfrom
Conversation
Owner
|
Hey @dtjm, thanks for your contribution! 👍 Could you please also execute the following command as per our recommendation (as it contains additional templating):
|
burningalchemist
requested changes
Jul 19, 2024
Owner
burningalchemist
left a comment
There was a problem hiding this comment.
We need to run make gen_docs to render docs automatically and submit the changes to the PR.
Contributor
Author
|
Thank you @burningalchemist , sorry I failed to actually read the instructions =) I've pushed that new rendering in eb65d16. |
Owner
|
@dtjm No worries, thanks for adding the changes. 👍 |
Contributor
Author
|
👍🏽 thank you for making this code open source! |
burningalchemist
approved these changes
Jul 19, 2024
Owner
|
v0.6.1 should be available shortly! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if I set
serviceMonitor.namespace, it overrides the namespace where the ServiceMonitor is deployed. However, the pod is deployed in the same namespace, so I'd like this to override the namespace inmatchNamespacespec field also.