docs(README): mention the feature of labels for multiple targets in jobs [skip ci]#462
Merged
burningalchemist merged 1 commit intoburningalchemist:masterfrom Mar 7, 2024
Conversation
Signed-off-by: Eve Fritz <eve.fritz@qonto.com>
qfritz
force-pushed
the
doc-labels-for-targets
branch
from
b238094 to
a7d6ce5
Compare
Owner
|
Hey @qfritz, thanks for your contribution! 👏 My next milestone is to rework the documentation completely, still trying to allocate some time for it. :) |
burningalchemist
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We faced some challenges with our team trying to include information in our jobs that had multiple targets, and couldn't use the static_labels in collectors in this specific case.
We were relying on the
job_name, but it didn't seem like the best approach. After doing some research, we discovered that sql_exporter actually already had a feature to address this issue, even though it wasn't documented.We've made a small addition to the README to help out any future users who may encounter the same issue as us.