fix: add flag to ignore results with missing values#422
Merged
burningalchemist merged 1 commit intomasterfrom Dec 29, 2023
Merged
fix: add flag to ignore results with missing values#422burningalchemist merged 1 commit intomasterfrom
burningalchemist merged 1 commit intomasterfrom
Conversation
burningalchemist
force-pushed
the
missing-values
branch
3 times, most recently
from
382b693 to
1e476d0
Compare
burningalchemist
force-pushed
the
missing-values
branch
from
1e476d0 to
18fda0e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #400
When set to true, errors on the missing values for the requested columns are reported at Info (Debug in the
klog-gokittranslation) log level, invisible by default.Setting this flag on reduces the amount of noisy log messages users are aware of (check the original user story). The metric with missing labels doesn't get collected nor reported as an invalid metric. Off by default.