feat(helm): Add an ability to set addition env via helm#399
Merged
burningalchemist merged 2 commits intoburningalchemist:masterfrom Nov 21, 2023
Merged
Conversation
added 2 commits
November 20, 2023 13:18
In case somebody wants to test the chart locally, after generating docs, tests will fail, because helm will consider bin as a part of the chart, and the size of the binary is too big to be installed to k8s
Now it should be possible to set addition environment variables that are going to be used by sql_exporter deployment. User can either set a value of the variable, so it's taken directly from Values, or use a value from an already existing Secret or ConfigMap.
allanger
force-pushed
the
add-SQLEXPORTER_TARGET_DSN-supprt
branch
from
2c88708 to
6d17086
Compare
Owner
|
Thanks, I'll review it shortly. 👍 |
burningalchemist
approved these changes
Nov 21, 2023
Owner
burningalchemist
left a comment
burningalchemist
left a comment
There was a problem hiding this comment.
Looks good to me! 👍🚀
Once we support more env variables on the sql_exporter side, this change should work just fine. 👍
burningalchemist
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.