feat: set 'static_value' per metric config#335
Merged
burningalchemist merged 1 commit intomasterfrom Sep 27, 2023
Merged
Conversation
5a627cf to
cf3c0bb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There are situations when we want to return some string data from the query (to re-process it later on the Prometheus side), and there's no value columns that could represent float64 number as a metric value. Even though we can solve it with some SQL adjustments, it's not always clear, when we look at SQL statements alone. It's also possible, that we simply cannot add a additional dummy value column due to different constraints (e.g. stored procedures we can't change) to point
valuesparameter to.To address this problem, we introduce metric configuration field
static_valuewhich can be set to a fixed number. The result is that we focus on the information mapped tokey_labelsinstead, the value itself doesn't need to mean anything (although, the commonly used value would be1) and can be ignored later on.valuesandstatic_valueare mutually exclusive parameters.References