fix: support NULL values for key labels#321
Merged
burningalchemist merged 3 commits intomasterfrom Sep 19, 2023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
At the moment, if at least one of the columns specified in
key_labelscontainsNULLin a row, the query will return the error and the metrics won't be published (for a single target). It's by design ofdatabase/sql- NULL is not an empty string, so it cannot be converted to a string out of the box.We actually want to support NULL values for metric labels (strings). If a row contains NULL in a column that's defined in
key_labels, we return its value as an empty string. In addition we create a log (under debug log level) message, that the column value is NULL for a particular row.Example
Sample Dataset:
Metric configuration:
The result:
fixes #317