fix: enable up and duration for target if named#315
Merged
burningalchemist merged 1 commit intomasterfrom Sep 10, 2023
Merged
Conversation
burningalchemist
force-pushed
the
fix/target-scrape-duration
branch
2 times, most recently
from
07b9f50 to
6c1cb82
Compare
burningalchemist
force-pushed
the
fix/target-scrape-duration
branch
from
6c1cb82 to
0588cf8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #303
This PR enables
up(availability) andscrape_durationmetrics for a single target iftarget.nameis populated in the config.Notes
Currently, the label
instanceis populated with target's name, which might look confusing. Given the fact thatjobsalso useinstancefor target names, we'll schedule the label change for both tov0.13for compatibility reasons.