feat: add AWS Secret Manager feature to store DSN#273
Conversation
|
Hey @elturkym, thank you for your contribution! Could you please fix the comment style (coming from |
config/config.go
Outdated
| // | ||
| //AWS Secret | ||
| // |
There was a problem hiding this comment.
As per the gofmt -d output:
| // | |
| //AWS Secret | |
| // | |
| // AWS Secret |
There was a problem hiding this comment.
Thanks, I have address this formatting issue.
There was a problem hiding this comment.
I think it's still not enough. We also need to remove heading and trailing slashes. Just like in the suggestion I made above. 🙂👍
There was a problem hiding this comment.
Thanks, will address that
a3cd747 to
0432c0b
Compare
|
My apologies, looks like there are new formatting issues, I will look at them. |
|
Sure, no worries. Check my last comment. 🙂👍 |
|
Hey @elturkym, do you need any help or assistance from my end to address the remaining issues? :) |
|
I was trying to run the workflow locally before submitting a new PR, but let me raise a new PR and check if there is still an error |
2af02da to
ca5f02d
Compare
This change allow AWS users, to store the database credentials in AWS Secret manager instead of adding the credentials in the configuration file directly.
Changes:
aws_secret_nameundertargetto store the data source name (DSN) which has the database connection info.