Skip to content

Comments

feat: add ability to not prepare statements#217

Merged
burningalchemist merged 2 commits intoburningalchemist:masterfrom
fffinkel:no-prepared-statement
Apr 20, 2023
Merged

feat: add ability to not prepare statements#217
burningalchemist merged 2 commits intoburningalchemist:masterfrom
fffinkel:no-prepared-statement

Conversation

@fffinkel
Copy link
Contributor

@fffinkel fffinkel commented Apr 3, 2023

Add this for cases when the backend does not support it

@burningalchemist
Copy link
Owner

burningalchemist commented Apr 4, 2023

Hi @fffinkel, thanks for your PR!

Could you please share a bit more details about the change? It's just for the history and better visibility of the PR. Just a few lines with an example would be perfect! :)

@fffinkel
Copy link
Contributor Author

Hey @burningalchemist, sorry for such a delay in response! We added this feature because we connect to ProxySQL, which does not properly support prepared statements.

@burningalchemist
Copy link
Owner

Hey @fffinkel, no worries. Got it, thanks. 👍

I need to fix one of the bugs first, but then I'll prioritize this PR. I just wanted to learn more about the use case to test it as well (and eventually cover everything with proper tests once I have a bit more time).

@burningalchemist burningalchemist added the enhancement New feature or request label Apr 13, 2023
@fffinkel
Copy link
Contributor Author

Thanks very much!

@srikiraju
Copy link

Oh wow, this is so timely @fffinkel, I was testing out this exporter right now for exactly the ProxySQL use case and ran into this problem and was considering whipping out a PR when I noticed this! Thanks for doing this.

@burningalchemist burningalchemist changed the title Add ability to not prepare statements feat: add ability to not prepare statements Apr 20, 2023
@burningalchemist burningalchemist merged commit 3386c93 into burningalchemist:master Apr 20, 2023
@srikiraju
Copy link

any chance we can get a release on this?

@burningalchemist
Copy link
Owner

Hey @srikiraju! Apologies, I haven't received the notification to the message. I'm preparing a new release next week. 👍 Will keep you posted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants