fix: don't fail immediately in resolveCollectorRefs nested loop

[unix-way]

This PR fixes a bug when resolveCollectorRefs() fails immediately in nested loop

sql_exporter/config/config.go

Lines 562 to 573 in dbe888f

	for _, cref := range collectorRefs {
	for k, c := range collectors {
	matched, err := filepath.Match(cref, k)
	if err != nil {
	return nil, fmt.Errorf("bad collector %q referenced in %s: %w", cref, ctx, err)
	}
	if !matched {
	return nil, fmt.Errorf("unknown collector %q referenced in %s", cref, ctx)
	}
	found[c] = true
	}
	}

Which actually happens every time there is a name mismatch in the slice and the map. For example, we have 3 collector files:

vertica_eon.collector.yml
vertica_ops.collector.yml
vertica_platform.collector.yml

And the following sql_exporter.yml with collectors specified without globbing

target:
  collectors:
    - vertica_ops
    - vertica_platform

collector_files:
  - '*.collector.yml'

In the inner loop, the function will compare vertica_ops against all collector names in the map and return an error when it hits either vertica_eon or vertica_platform, which is an unexpected behavior. The function should continue instead and return an error only if there are no matching collectors.

[burningalchemist]

Hi @unix-way, yeah, good catch. Thanks a lot for your contribution! 👍

[hhromic]

Hi @unix-way !
I introduced this bug in my PR that added globbing support 🙈. Apologies for breaking your setup 😢.
Should have tested it better. Thanks for finding the issue and fixing it.