feat: add globbing support to collector refs in config#194
Merged
burningalchemist merged 2 commits intoburningalchemist:masterfrom Jan 31, 2023
hhromic:add-collrefs-glob
Merged
feat: add globbing support to collector refs in config#194burningalchemist merged 2 commits intoburningalchemist:masterfrom hhromic:add-collrefs-glob
burningalchemist merged 2 commits intoburningalchemist:masterfrom
hhromic:add-collrefs-glob
Conversation
Owner
|
Hey @hhromic, looks good to me! 👍 Let me play with it a bit before approving. 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements support for glob patterns (see linked issue) in the
collectorsconfiguration oftarget(andjobs).This change is almost non-breaking because glob patterns without matching terms act as exact string matchers, i.e. the previous behaviour for the
collectorsconfiguration. However, the catch is that users using matching terms, e.g.*,?,[,]or^, in their collector names (a very unlikely but possible case) must now escape those characters.The implementation is not perfectly efficient as it adds an inner
for-loop and uses amapduring collector resolving to ensure that collectors matching multiple patterns are only added once to the outputresolvedarray. However, I don't think this is a big issue in practice. In any case let me know if you have any feedback.Resolves #184