Missing job target labels

[Maros112358]

Describe the bug
In sql_exporter 0.12.1, I used labels defined in jobs to add custom labels to my metrics. In sql_exporter 0.12.2, these labels do not work anymore. I am not sure if this was intentional change, but I still see labels in the source code

To Reproduce
Steps to reproduce the behavior:

1. Start sql_exporter with config like below
2. Go to /metrics

Expected behavior
I expected each and every metric to have label my_label_key=my_label_value.

Configuration
Example config:

jobs:
  - job_name: my_job
    collectors: [mssql_standard]
    static_configs:
      - targets:
          'my_target': 'connection_string'
        labels:
          my_label_key: my_label_value

[burningalchemist]

Hey @Maros112358, I'll have a look, although there are no changes related to job labels at all in 0.12.2. Please check and post some debug logs if possible? That would help.

[Maros112358]

Thank you for quick answer, @burningalchemist.
I just ran locally both 0.12.1 and 0.12.2 with the same config I provided above.

Logs from 0.12.1:

ts=2023-09-20T14:29:24.546Z caller=klog.go:108 level=warn func=Warningf msg="Starting SQL exporter (version=0.12.1, branch=HEAD, revision=1cfbd6095ac7303621a73aef74841721dc2e22c2) (go=go1.20.7, platform=darwin/arm64, user=root@86afecba0516, date=20230821-10:02:30, tags=netgo)"
ts=2023-09-20T14:29:24.546Z caller=klog.go:84 level=debug func=Infof msg="Loading configuration from sql_exporter.yml"
ts=2023-09-20T14:29:24.546Z caller=klog.go:55 level=debug func=Verbose.Infof msg="[job=\"my_job\", target=\"my_target\", collector=\"mssql_standard\"] Non-zero min_interval (30s), using cached collector."
ts=2023-09-20T14:29:24.546Z caller=klog.go:96 level=warn func=Warning msg="Listening on :9399"
ts=2023-09-20T14:29:24.547Z caller=tls_config.go:274 level=info msg="Listening on" address=[::]:9399
ts=2023-09-20T14:29:24.547Z caller=tls_config.go:277 level=info msg="TLS is disabled." http2=false address=[::]:9399
ts=2023-09-20T14:29:26.614Z caller=klog.go:84 level=debug func=Infof msg="[job=\"my_job\", target=\"my_target\"] Database handle successfully opened with 'sqlserver' driver"
ts=2023-09-20T14:29:26.614Z caller=klog.go:55 level=debug func=Verbose.Infof msg="[job=\"my_job\", target=\"my_target\", collector=\"mssql_standard\"] Collecting fresh metrics: min_interval=30.000s cache_age=9223372036.855s"
ts=2023-09-20T14:29:26.879Z caller=klog.go:55 level=debug func=Verbose.Infof msg="returned_columns=\"[cntr_value]\"job=\"my_job\", target=\"my_target\", collector=\"mssql_standard\", query=\"mssql_kill_connection_errors\""
ts=2023-09-20T14:29:26.881Z caller=klog.go:55 level=debug func=Verbose.Infof msg="returned_columns=\"[cntr_value]\"job=\"my_job\", target=\"my_target\", collector=\"mssql_standard\", query=\"mssql_page_life_expectancy_seconds\""
ts=2023-09-20T14:29:26.882Z caller=klog.go:55 level=debug func=Verbose.Infof msg="returned_columns=\"[cntr_value]\"job=\"my_job\", target=\"my_target\", collector=\"mssql_standard\", query=\"mssql_buffer_cache_hit_ratio\""
ts=2023-09-20T14:29:26.889Z caller=klog.go:55 level=debug func=Verbose.Infof msg="returned_columns=\"[db count]\"job=\"my_job\", target=\"my_target\", collector=\"mssql_standard\", query=\"mssql_connections\""
ts=2023-09-20T14:29:26.893Z caller=klog.go:55 level=debug func=Verbose.Infof msg="returned_columns=\"[cntr_value]\"job=\"my_job\", target=\"my_target\", collector=\"mssql_standard\", query=\"mssql_checkpoint_pages_sec\""
ts=2023-09-20T14:29:26.899Z caller=klog.go:55 level=debug func=Verbose.Infof msg="returned_columns=\"[unix_time]\"job=\"my_job\", target=\"my_target\", collector=\"mssql_standard\", query=\"mssql_local_time_seconds\""
ts=2023-09-20T14:29:26.900Z caller=klog.go:55 level=debug func=Verbose.Infof msg="returned_columns=\"[cntr_value]\"job=\"my_job\", target=\"my_target\", collector=\"mssql_standard\", query=\"mssql_batch_requests\""
ts=2023-09-20T14:29:26.901Z caller=klog.go:55 level=debug func=Verbose.Infof msg="returned_columns=\"[cntr_value]\"job=\"my_job\", target=\"my_target\", collector=\"mssql_standard\", query=\"mssql_deadlocks\""
ts=2023-09-20T14:29:26.901Z caller=klog.go:55 level=debug func=Verbose.Infof msg="returned_columns=\"[db cntr_value]\"job=\"my_job\", target=\"my_target\", collector=\"mssql_standard\", query=\"mssql_log_growths\""
ts=2023-09-20T14:29:26.952Z caller=klog.go:55 level=debug func=Verbose.Infof msg="returned_columns=\"[cntr_value]\"job=\"my_job\", target=\"my_target\", collector=\"mssql_standard\", query=\"mssql_user_errors\""

Returned metric:

mssql_batch_requests{instance="my_target",job="my_job",my_label_key="my_label_value"} 2.86654873e+09

Log from 0.12.2:

ts=2023-09-20T14:27:23.194Z caller=klog.go:108 level=warn func=Warningf msg="Starting SQL exporter (version=0.12.2, branch=HEAD, revision=588b42d329deb17d86b50de94c52bc3dca264b0c) (go=go1.20.8, platform=darwin/arm64, user=root@4d35747bd17e, date=20230915-10:30:11, tags=netgo)"
ts=2023-09-20T14:27:23.194Z caller=klog.go:84 level=debug func=Infof msg="Loading configuration from sql_exporter.yml"
ts=2023-09-20T14:27:23.194Z caller=klog.go:84 level=debug func=Infof msg="Resolved collectors for job \"my_job\": 1"
ts=2023-09-20T14:27:23.194Z caller=klog.go:55 level=debug func=Verbose.Infof msg="[job=\"my_job\", target=\"my_target\", collector=\"mssql_standard\"] Non-zero min_interval (30s), using cached collector."
ts=2023-09-20T14:27:23.194Z caller=tls_config.go:274 level=info msg="Listening on" address=[::]:9399
ts=2023-09-20T14:27:23.194Z caller=tls_config.go:277 level=info msg="TLS is disabled." http2=false address=[::]:9399
ts=2023-09-20T14:27:34.595Z caller=klog.go:84 level=debug func=Infof msg="[job=\"my_job\", target=\"my_target\"] Database handle successfully opened with 'sqlserver' driver"
ts=2023-09-20T14:27:34.595Z caller=klog.go:55 level=debug func=Verbose.Infof msg="[job=\"my_job\", target=\"my_target\", collector=\"mssql_standard\"] Collecting fresh metrics: min_interval=30.000s cache_age=9223372036.855s"
ts=2023-09-20T14:27:34.917Z caller=klog.go:55 level=debug func=Verbose.Infof msg="returned_columns=\"[db cntr_value]\"job=\"my_job\", target=\"my_target\", collector=\"mssql_standard\", query=\"mssql_log_growths\""
ts=2023-09-20T14:27:34.932Z caller=klog.go:55 level=debug func=Verbose.Infof msg="returned_columns=\"[db count]\"job=\"my_job\", target=\"my_target\", collector=\"mssql_standard\", query=\"mssql_connections\""
ts=2023-09-20T14:27:34.932Z caller=klog.go:55 level=debug func=Verbose.Infof msg="returned_columns=\"[cntr_value]\"job=\"my_job\", target=\"my_target\", collector=\"mssql_standard\", query=\"mssql_batch_requests\""
ts=2023-09-20T14:27:34.939Z caller=klog.go:55 level=debug func=Verbose.Infof msg="returned_columns=\"[unix_time]\"job=\"my_job\", target=\"my_target\", collector=\"mssql_standard\", query=\"mssql_local_time_seconds\""
ts=2023-09-20T14:27:34.967Z caller=klog.go:55 level=debug func=Verbose.Infof msg="returned_columns=\"[cntr_value]\"job=\"my_job\", target=\"my_target\", collector=\"mssql_standard\", query=\"mssql_deadlocks\""
ts=2023-09-20T14:27:34.977Z caller=klog.go:55 level=debug func=Verbose.Infof msg="returned_columns=\"[cntr_value]\"job=\"my_job\", target=\"my_target\", collector=\"mssql_standard\", query=\"mssql_user_errors\""
ts=2023-09-20T14:27:35.001Z caller=klog.go:55 level=debug func=Verbose.Infof msg="returned_columns=\"[cntr_value]\"job=\"my_job\", target=\"my_target\", collector=\"mssql_standard\", query=\"mssql_buffer_cache_hit_ratio\""
ts=2023-09-20T14:27:35.007Z caller=klog.go:55 level=debug func=Verbose.Infof msg="returned_columns=\"[cntr_value]\"job=\"my_job\", target=\"my_target\", collector=\"mssql_standard\", query=\"mssql_checkpoint_pages_sec\""
ts=2023-09-20T14:27:35.011Z caller=klog.go:55 level=debug func=Verbose.Infof msg="returned_columns=\"[cntr_value]\"job=\"my_job\", target=\"my_target\", collector=\"mssql_standard\", query=\"mssql_kill_connection_errors\""
ts=2023-09-20T14:27:35.046Z caller=klog.go:55 level=debug func=Verbose.Infof msg="returned_columns=\"[cntr_value]\"job=\"my_job\", target=\"my_target\", collector=\"mssql_standard\", query=\"mssql_page_life_expectancy_seconds\""

Returned metric:

mssql_batch_requests{instance="my_target"} 2.866647516e+09

[burningalchemist]

Got it, thanks. I'll have a look shortly, seems like an unexpected regression. 👍

[burningalchemist]

@Maros112358 Found it, thanks for reporting! 👍

[burningalchemist]

Yeah, sorry for the inconvenience. I'll release shortly. I'm trying to deliver a bunch of features and then focus on a good test coverage. It's tricky, since the original codebase wasn't implemented by me. So far I mostly rely upon my own testing and occasional beta-testers. 🙂👍

[Maros112358]

Thank you very much for the quick reaction. 😁 I understand your situation. Will try to help on the codebase if possible. 👍

[burningalchemist]

Releasing it now, please try it out and let me know? Should be available in 30mins or so. Together with the partial results request. 👍

[Maros112358]

I tried it out. Looks good to me. Good job. 👍