Merged
Conversation
OGKevin
requested review from
andrederoos and
sandervdo
and removed request for
andrederoos
Contributor
Author
|
@sandervdo please 👀 |
sandervdo
suggested changes
Mar 29, 2018
| * @throws ForbiddenException | ||
| */ | ||
| private function setupContext() | ||
| private function setupContext(bool $resetConfigIfNeeded = true) |
Contributor
Author
There was a problem hiding this comment.
This is not the backend tho :P here we follow the psr style guide. AFAIK there is no mention of not type hinting bools 🤔
There was a problem hiding this comment.
@OGKevin as long as you don't suffer from the weird casting shizzle I'm fine with it.
Contributor
Author
There was a problem hiding this comment.
@sandervdo nope we don't suffer from this 😬
sandervdo
approved these changes
Mar 29, 2018
Contributor
Author
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11