-
Notifications
You must be signed in to change notification settings - Fork 13
Help center: Custom CSS & head injection #416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for bump-content-hub ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
It is not mandatory, but it is an option. Another option is to request us to apply those changes, as soon as they have a Business subscription. |
Yes, I explained it in the article (that we can also handle it). But I wanted to be sure that it was indeed a reverse proxy that was needed (and not a simple proxy) if they want to handle it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, I think it's key to first think in terms of "what the users want to achieve", and then "how they can achieve it". They have at first no idea how it will work for them to track doc views with their Google Analytics, but that is precisely want they want to do.
|
I added your change requests @ChristopheDujarric 🙏 |
src/_data/sidebars/help.yml
Outdated
| link: /customization-options/login/ | ||
| - label: Operations & Navigation | ||
| link: /customization-options/operations-navigation/ | ||
| - label: Deep customization, injection & analytics |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the additional back-and-forth, but I'm wondering if the whole section on CSS shouldn't be in the https://docs.bump.sh/help/customization-options/color-logo-meta-images/ page, under an "Advanced customization" paragraph.
This is yet the best way to answer all the questions people will have on that part of the branding customization.
It then gives more space to "Analytics and front-end integrations". Unless I got it wrong, the part with JS customization can, for instance, let people embed stuff such as Intercom too, right? Not sure if "front-end" in "front-end integrations" is the best naming, but that's where I'd be headed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could. I would just have to duplicate the explanation about the reverse proxy there too 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reworked the global structure based on your comments. 🙏
Content is now splitted between "Branding customization" and "head injection (analytics and tools integration)"
Hey!
I added a new section describing how to inject content into the
headtag, and the CSS variables that can be used.We had that listing in the Embed mode page, but I think it makes sense to also have it "standalone", as users might want to customize their docs without embedding it.
I also updated the list of CSS variables based on the recent rework we dit on it.
❓I need one confirmation: I wrote that a reverse-proxy is mandatory to inject these customization options (unless we handle it on our end for the client). ✅