Skip to content

Conversation

@grossyoan
Copy link
Contributor

@grossyoan grossyoan commented Oct 30, 2025

Hey!

I added a new section describing how to inject content into the head tag, and the CSS variables that can be used.

We had that listing in the Embed mode page, but I think it makes sense to also have it "standalone", as users might want to customize their docs without embedding it.

I also updated the list of CSS variables based on the recent rework we dit on it.

❓I need one confirmation: I wrote that a reverse-proxy is mandatory to inject these customization options (unless we handle it on our end for the client). ✅

@grossyoan grossyoan requested review from jayk-u and paulRbr October 30, 2025 12:44
@netlify
Copy link

netlify bot commented Oct 30, 2025

Deploy Preview for bump-content-hub ready!

Name Link
🔨 Latest commit 9f34c00
🔍 Latest deploy log https://app.netlify.com/projects/bump-content-hub/deploys/6908b63f8a62c900087e469a
😎 Deploy Preview https://deploy-preview-416--bump-content-hub.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@ChristopheDujarric
Copy link
Contributor

❓I need one confirmation: I wrote that a reverse-proxy is mandatory to inject these customization options (unless we handle it on our end for the client).

It is not mandatory, but it is an option. Another option is to request us to apply those changes, as soon as they have a Business subscription.

@grossyoan grossyoan self-assigned this Oct 30, 2025
@grossyoan
Copy link
Contributor Author

❓I need one confirmation: I wrote that a reverse-proxy is mandatory to inject these customization options (unless we handle it on our end for the client).

It is not mandatory, but it is an option. Another option is to request us to apply those changes, as soon as they have a Business subscription.

Yes, I explained it in the article (that we can also handle it). But I wanted to be sure that it was indeed a reverse proxy that was needed (and not a simple proxy) if they want to handle it.

Copy link
Contributor

@ChristopheDujarric ChristopheDujarric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, I think it's key to first think in terms of "what the users want to achieve", and then "how they can achieve it". They have at first no idea how it will work for them to track doc views with their Google Analytics, but that is precisely want they want to do.

@grossyoan
Copy link
Contributor Author

I added your change requests @ChristopheDujarric 🙏

link: /customization-options/login/
- label: Operations & Navigation
link: /customization-options/operations-navigation/
- label: Deep customization, injection & analytics
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the additional back-and-forth, but I'm wondering if the whole section on CSS shouldn't be in the https://docs.bump.sh/help/customization-options/color-logo-meta-images/ page, under an "Advanced customization" paragraph.

This is yet the best way to answer all the questions people will have on that part of the branding customization.

It then gives more space to "Analytics and front-end integrations". Unless I got it wrong, the part with JS customization can, for instance, let people embed stuff such as Intercom too, right? Not sure if "front-end" in "front-end integrations" is the best naming, but that's where I'd be headed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could. I would just have to duplicate the explanation about the reverse proxy there too 🙏

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reworked the global structure based on your comments. 🙏

Content is now splitted between "Branding customization" and "head injection (analytics and tools integration)"

@grossyoan grossyoan requested review from ChristopheDujarric and removed request for jayk-u and paulRbr November 3, 2025 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants