fix: align exported core Diff interface with previous 2.8 signature #608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a fix after the major upgrade of the CLI (in bump-sh#587) where we broke the interface of the exported core `Diff` class and made its usage as a lib more complicated. Let's align back to what it used to be, and even simplify the interface by making the constructor argument optional.
|
@fbraure this is the PR I talked to you about yesterday. I broke the interface of the exported Could you please review so I can release a new version of the CLI, and then be able to finish bump-sh/github-action#508 please 🙏 |
paulRbr
force-pushed
the
fix-core-diff-interface
branch
from
f965582 to
60d0542
Compare
fbraure
reviewed
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix after the major upgrade of the CLI (in #587) where we
broke the interface of the exported core
Diffclass and made itsusage as a lib more complicated.
Let's align back to what it used to be, and even simplify the
interface by making the constructor argument optional.