Skip to content

Prototype with pager #721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 32 commits into
base: 1.x
Choose a base branch
from
Open

Prototype with pager #721

wants to merge 32 commits into from

Conversation

vladcipariu91
Copy link
Collaborator

Won't merge, just showcasing the pager

KovalevAndrey and others added 30 commits April 22, 2024 14:47
@KovalevAndrey
Merge pull request bumble-tech#695 from KovalevAndrey/1.x-release-1.5.0
331fd6c 
Release 1.5.0
@KovalevAndrey
Merge branch '1.x' of github.com:bumble-tech/appyx into 1.x
4f37347
@KovalevAndrey
Shared element transition integration
9184c21
@KovalevAndrey
Update CHANGELOG.md
e2b687a
@KovalevAndrey
Replace SharedTransitionLayout with Box where no sharedElement is sup…
984a512 
…ported
@KovalevAndrey
Update crashing lint
c1c570d
@KovalevAndrey
Movable content support and test for targetVisibilityState
06a138c
@KovalevAndrey
Update detekt-baseline.xml
18ef892
@KovalevAndrey
Rename button to Shared element with movable content
bec8f87
@KovalevAndrey
Update emulator API
378564a
@KovalevAndrey
Add documentation for movable content and shared element transition
53bed47
@KovalevAndrey
Update CHANGELOG.md
734b49f
@KovalevAndrey
Add docs and uninstall test app
960e194
@KovalevAndrey
Uninstall RIBs test apk
3d45d48
@KovalevAndrey
Rename package and uninstall navigation compose test apk
7dfbbfb
@KovalevAndrey
Fix compilation error
592133a
@KovalevAndrey
Fix compilation error
155d01e
@KovalevAndrey
Merge branch '1.x-shared-element-prototype' of github.com:KovalevAndr…
1411eed 
…ey/appyx into 1.x-shared-element-prototype
@KovalevAndrey
Add proguard rules release to sandbox app
c3290b3
@KovalevAndrey
Fix testing package name
def253f
@KovalevAndrey
Update compose to alpha08
a6d22a1
@KovalevAndrey
Temporary remove uninstalling com.bumble.appyx.sample.navigation.comp…
ade37a3 
…ose.test
@KovalevAndrey
Update to alpha08
5131031
@KovalevAndrey @manuelvicnt
Update documentation/ui/transitions.md
e9e5b4f 
Co-authored-by: Manuel Vivo <manuelvicnt@gmail.com>
@KovalevAndrey @manuelvicnt
Update documentation/ui/transitions.md
8a1c9d1 
Co-authored-by: Manuel Vivo <manuelvicnt@gmail.com>
@KovalevAndrey @manuelvicnt
Update libraries/core/src/main/kotlin/com/bumble/appyx/core/composabl…
aeb4eb5 
…e/Children.kt

Co-authored-by: Manuel Vivo <manuelvicnt@gmail.com>
@KovalevAndrey @manuelvicnt
Update documentation/ui/transitions.md
695b88c 
Co-authored-by: Manuel Vivo <manuelvicnt@gmail.com>
@KovalevAndrey
- Added shared element example without movable content
76d6c1f 
- Moved LocalMovableContentMap to Children composable and added a parameter to it.
- Added support for more movableContent API variants
@KovalevAndrey
Add withMovableContent param to docs
9909b89
@KovalevAndrey
Merge branch 'main' of github.com:KovalevAndrey/appyx into shared-ele…
f7d86d3 
…ment-prototype-copy
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 8, 2025
View reviewed changes
...n/kotlin/com/bumble/appyx/sandbox/client/sharedelement/with_pager/ShareElementDetailsNode.kt
@@ -0,0 +1,4 @@
package com.bumble.appyx.sandbox.client.sharedelement.with_pager

Check warning

Code scanning / detekt

Package names should match the naming convention set in the configuration. Warning

Package name should match the pattern: [a-z]+(.[a-z][A-Za-z0-9]*)*
...n/kotlin/com/bumble/appyx/sandbox/client/sharedelement/with_pager/ShareElementDetailsNode.kt
Comment on lines +3 to +4
class ShareElementDetailsNode {
} No newline at end of file

Check warning

Code scanning / detekt

Empty block of code detected. As they serve no purpose they should be removed. Warning

The class or object ShareElementDetailsNode is empty.
...n/kotlin/com/bumble/appyx/sandbox/client/sharedelement/with_pager/ShareElementDetailsNode.kt
package com.bumble.appyx.sandbox.client.sharedelement.with_pager

class ShareElementDetailsNode {
} No newline at end of file

Check warning

Code scanning / detekt

Checks whether files end with a line separator. Warning

The file /home/runner/work/appyx/appyx/samples/sandbox/src/main/kotlin/com/bumble/appyx/sandbox/client/sharedelement/with_pager/ShareElementDetailsNode.kt is not ending with a new line.
...in/kotlin/com/bumble/appyx/sandbox/client/sharedelement/with_pager/SharedElementPagerNode.kt
@@ -0,0 +1,4 @@
package com.bumble.appyx.sandbox.client.sharedelement.with_pager

Check warning

Code scanning / detekt

Package names should match the naming convention set in the configuration. Warning

Package name should match the pattern: [a-z]+(.[a-z][A-Za-z0-9]*)*
...in/kotlin/com/bumble/appyx/sandbox/client/sharedelement/with_pager/SharedElementPagerNode.kt
Comment on lines +3 to +4
class SharedElementPagerNode {
} No newline at end of file

Check warning

Code scanning / detekt

Empty block of code detected. As they serve no purpose they should be removed. Warning

The class or object SharedElementPagerNode is empty.
...in/kotlin/com/bumble/appyx/sandbox/client/sharedelement/with_pager/SharedElementPagerNode.kt
package com.bumble.appyx.sandbox.client.sharedelement.with_pager

class SharedElementPagerNode {
} No newline at end of file

Check warning

Code scanning / detekt

Checks whether files end with a line separator. Warning

The file /home/runner/work/appyx/appyx/samples/sandbox/src/main/kotlin/com/bumble/appyx/sandbox/client/sharedelement/with_pager/SharedElementPagerNode.kt is not ending with a new line.
...lin/com/bumble/appyx/sandbox/client/sharedelement/with_pager/SharedElementPagerParentNode.kt
@@ -0,0 +1,146 @@
package com.bumble.appyx.sandbox.client.sharedelement.with_pager

Check warning

Code scanning / detekt

Package names should match the naming convention set in the configuration. Warning

Package name should match the pattern: [a-z]+(.[a-z][A-Za-z0-9]*)*
...lin/com/bumble/appyx/sandbox/client/sharedelement/with_pager/SharedElementPagerParentNode.kt
}

@OptIn(ExperimentalSharedTransitionApi::class)
override fun resolve(navTarget: NavTarget, buildContext: BuildContext): Node {

Check warning

Code scanning / detekt

One method should have one responsibility. Long methods tend to handle many things at once. Prefer smaller methods to make them easier to understand. Warning

The function resolve is too long (67). The maximum length is 60.
...lin/com/bumble/appyx/sandbox/client/sharedelement/with_pager/SharedElementPagerParentNode.kt
transitionHandler = rememberBackstackFader(transitionSpec = { tween(300) })
)
}
} No newline at end of file

Check warning

Code scanning / detekt

Checks whether files end with a line separator. Warning

The file /home/runner/work/appyx/appyx/samples/sandbox/src/main/kotlin/com/bumble/appyx/sandbox/client/sharedelement/with_pager/SharedElementPagerParentNode.kt is not ending with a new line.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vladcipariu91 @KovalevAndrey